Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (accounting-integrations): send webhook for incomplete payload #2600

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix (accounting-integrations): send webhook for incomplete payload #2600

merged 2 commits into from
Sep 19, 2024

Conversation

lovrocolic
Copy link
Collaborator

Context

For invalid payload due to incomplete configuration, we raise error (500) instead of silently notifying users via webhooks.

Description

This PR covers described scenario

ivannovosad
ivannovosad approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ivannovosad ivannovosad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lovrocolic lovrocolic merged commit 0be7efb into main Sep 19, 2024
6 checks passed
@lovrocolic lovrocolic deleted the fix-integrations-payload-error branch September 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivannovosad ivannovosad ivannovosad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovrocolic @ivannovosad